On Thu, Apr 20, 2023 at 09:56:26AM +0800, Jiawen Wu wrote: > On Wednesday, April 19, 2023 9:20 PM, Vladimir Oltean wrote: > > On Wed, Apr 19, 2023 at 04:27:37PM +0800, Jiawen Wu wrote: > > > Add basic support for XPCS using 10GBASE-R interface. This mode will > > > be extended to use interrupt, so set pcs.poll false. And avoid soft > > > reset so that the device using this mode is in the default configuration. > > > > I'm not clear why the xpcs_soft_reset() call is avoided. Isn't the > > out-of-reset configuration the "default" one? > > Theoretically so, I need to configure 10GBASE-R mode after reset. But this > configuration involves board info to configure PMA, etc., I'd like to implement > it in the next patch. Now the "default" configuration refers to the mode in > which the firmware is configured. How much extra complexity are we talking about, to not depend on the configuration done by the bootloader?