Re: [PATCH 2/2] i2c: xiic: xiic_xfer(): Fix runtime PM leak on error path

[Michal Simek <michal.simek@xxxxxxx>]

On 4/14/23 04:10, Lars-Peter Clausen wrote:
> The xiic_xfer() function gets a runtime PM reference when the function is
> entered. This reference is released when the function is exited. There is
> currently one error path where the function exits directly, which leads to
> a leak of the runtime PM reference.
>
> Make sure that this error path also releases the runtime PM reference.
>
> Fixes: fdacc3c7405d ("i2c: xiic: Switch from waitqueue to completion")
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> ---
>   drivers/i2c/busses/i2c-xiic.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index e7d37eb20f2b..8a3d9817cb41 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1164,7 +1164,7 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
>   	err = xiic_start_xfer(i2c, msgs, num);
>   	if (err < 0) {
>   		dev_err(adap->dev.parent, "Error xiic_start_xfer\n");
> -		return err;
> +		goto out;
>   	}
>   
>   	err = wait_for_completion_timeout(&i2c->completion, XIIC_XFER_TIMEOUT);
> @@ -1178,6 +1178,8 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
>   		err = (i2c->state == STATE_DONE) ? num : -EIO;
>   	}
>   	mutex_unlock(&i2c->lock);
> +
> +out:
>   	pm_runtime_mark_last_busy(i2c->dev);
>   	pm_runtime_put_autosuspend(i2c->dev);
>   	return err;

Reviewed-by: Michal Simek <michal.simek@xxxxxxx>

Thanks,
Michal