Hi Mark, It was using the normal regulator_get() in the last revision, but Sergey requested to make it optional. Please advise me what to do here? Who is right? Regards, Patrick On Fri, Apr 14, 2023 at 1:47 PM Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Fri, Apr 14, 2023 at 01:01:36PM +0200, Patrick Rudolph wrote: > > > + data->supply = devm_regulator_get_optional(dev, "vdd"); > > + if (IS_ERR(data->supply)) { > > + ret = PTR_ERR(data->supply); > > Unless the device can work without power it should be using a normal > regulator_get().