On Thu, Apr 13, 2023 at 04:49:13PM +0200, Benjamin Tissoires wrote: > As you should have seen in the automatic replied, I took that series in > because it seems to fix a rather worrying bug. Thanks! > Also, just a side note, this driver is very limited in term of scope, as > it only touches one dedicated device. Which means that whatever solution > feels the more elegant to you has a good chance of being accepted :) Well, using a struct to describe the layout of a message seems more elegant; but if I'm not mistaken, taking offsets of fields in a packed struct is UB... so I was surprised to even see that in Linux, that's why I was wondering if I should pursue in that direction. -- Louis
