On Thu, Apr 13, 2023 at 07:10:56PM +0300, Andy Shevchenko wrote: > On Thu, Apr 13, 2023 at 03:53:27PM +0800, Ryan Chen wrote: > > Add i2c new register mode driver to support AST2600 i2c > > new register mode. AST2600 i2c controller have legacy and > > new register mode. The new register mode have global register > > support 4 base clock for scl clock selection, and new clock > > divider mode. The i2c new register mode have separate register > > set to control i2c master and slave. > > There is already i2c-aspeed.c in the kernel. Can you elaborate what's wrong > with the extending existing driver? (It seems to me that so called "legacy" > mode is exactly what is being serviced by that driver.) Okay, it seems the answer is in cover letter. -- With Best Regards, Andy Shevchenko
