On Tue, 04 Apr 2023 14:14:58 +0200, Louis Morhet wrote: > The mcp2221 HID driver exposes a gpiochip device. > While gpioset seemed to work fine, gpioget always returned 1 on all 4 > GPIOs of the component (0x01 for input in the field "direction", > according to the documentation). > > This patch series addresses this issue by fixing the order of the fields > in the driver's representation of the chip answer, and adding > consistency to the way the callbacks prepare their command and the way > the hid event handler gets these fields. > The set callbacks use a similar mechanism, but work for now because > setting a direction/value only requires gpio-specific positioning in the > command preparation, and not in the raw_event handler. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-6.4/mcp2221), thanks! [1/2] HID: mcp2221: fix report layout for gpio get https://git.kernel.org/hid/hid/c/e36c31f8cac5 [2/2] HID: mcp2221: fix get and get_direction for gpio https://git.kernel.org/hid/hid/c/ca6961d8a851 Cheers, -- Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
