Re: [PATCH 2/2] i2c: i801: Add support for Intel Meteor Lake PCH-S

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/3/23 19:03, Jean Delvare wrote:
Hi Jarkko,

On Thu, 30 Mar 2023 13:55:02 +0300, Jarkko Nikula wrote:
Add SMBus PCI ID on Intel Meteor Lake PCH-S. Also called as Meteor
Point-S which is used in the code to distinguish from Meteor Lake-S SoC
but call both as Meteor Lake in documentation and Kconfig.

Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
---
  Documentation/i2c/busses/i2c-i801.rst | 2 +-
  drivers/i2c/busses/Kconfig            | 2 +-
  drivers/i2c/busses/i2c-i801.c         | 3 +++
  3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/i2c/busses/i2c-i801.rst b/Documentation/i2c/busses/i2c-i801.rst
index ab9e850e8fe0..e62a62323f36 100644
--- a/Documentation/i2c/busses/i2c-i801.rst
+++ b/Documentation/i2c/busses/i2c-i801.rst
@@ -46,7 +46,7 @@ Supported adapters:
    * Intel Emmitsburg (PCH)
    * Intel Alder Lake (PCH)
    * Intel Raptor Lake (PCH)
-  * Intel Meteor Lake (SOC)
+  * Intel Meteor Lake (SOC/PCH)

I'm confused. The patch actually adds support for Meteor Point (S). So
shouldn't you add:
     * Intel Meteor Point (PCH)

instead of modifying the existing line?

Idea was to follow my earlier commit 80d943ab19e9 ("i2c: i801: Consolidate chipset names in documentation and Kconfig") to use single name for the same family instead of listing all possible variants.

Like here we have already support for Meteor Lake -P SoC and now adding support for Meteor Lake -S that will have both in SoC SMBus and PCH SMBus controllers.

I realized actually Alder Lake (PCH) above may not be correct. True for Alder Lake -S PCH but now thinking -P and -M variants may be actually SoCs.

Confusing, yes I agree :-)




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux