Hi Benjamin, Thank you for the patch! Yet something to improve: [auto build test ERROR on ec0a1b360aec1ba0bdfad3dd69e300b028529c0d] url: https://github.com/intel-lab-lkp/linux/commits/Benjamin-Gray/i2c-Build-I2C_PASEMI-with-COMPILE_TEST/20230228-073442 base: ec0a1b360aec1ba0bdfad3dd69e300b028529c0d patch link: https://lore.kernel.org/r/20230227233318.120415-2-bgray%40linux.ibm.com patch subject: [PATCH v2 2/2] i2c: Build I2C_PASEMI with COMPILE_TEST config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230228/202302281135.KsarHDzl-lkp@xxxxxxxxx/config) compiler: sh4-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/6f8f477a04ff9dcd1091aed71674b27c513b6b39 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Benjamin-Gray/i2c-Build-I2C_PASEMI-with-COMPILE_TEST/20230228-073442 git checkout 6f8f477a04ff9dcd1091aed71674b27c513b6b39 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/i2c/busses/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202302281135.KsarHDzl-lkp@xxxxxxxxx/ All error/warnings (new ones prefixed by >>): >> drivers/i2c/busses/i2c-pasemi-pci.c:82:1: warning: data definition has no type or storage class 82 | module_pci_driver(pasemi_smb_pci_driver); | ^~~~~~~~~~~~~~~~~ >> drivers/i2c/busses/i2c-pasemi-pci.c:82:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int] >> drivers/i2c/busses/i2c-pasemi-pci.c:82:1: warning: parameter names (without types) in function declaration cc1: some warnings being treated as errors vim +82 drivers/i2c/busses/i2c-pasemi-pci.c 9bc5f4f660ff3e Sven Peter 2021-10-08 81 9bc5f4f660ff3e Sven Peter 2021-10-08 @82 module_pci_driver(pasemi_smb_pci_driver); 9bc5f4f660ff3e Sven Peter 2021-10-08 83 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
