Re: [PATCH] i2c: xiic: Remove some dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2/15/23 11:38, Christophe JAILLET wrote:

wait_for_completion_timeout() never returns negative value.

Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
---
  drivers/i2c/busses/i2c-xiic.c | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index 8503b5016aaf..5543f372ae60 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -1038,10 +1038,6 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
                 i2c->rx_msg = NULL;
                 i2c->nmsgs = 0;
                 err = -ETIMEDOUT;
-       } else if (err < 0) {   /* Completion error */
-               i2c->tx_msg = NULL;
-               i2c->rx_msg = NULL;
-               i2c->nmsgs = 0;
         } else {
                 err = (i2c->state == STATE_DONE) ? num : -EIO;
         }
--
2.34.1


Reviewed-by: Michal Simek <michal.simek@xxxxxxx>

Thanks,
Michal



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux