On Wed, Jan 25, 2023 at 12:13:23PM +0200, Laurent Pinchart wrote: > On Wed, Jan 25, 2023 at 09:39:57AM +0200, Tomi Valkeinen wrote: ... > I find > > dev_dbg(dev, read_err_str, port, "ti,cdr-mode", ret); > > less readable as I then have to look up the read_err_str string to > understand that line. I also wonder, in that case, if the compiler can > still warn if the format string doesn't match the argument types. Sorry to be a bit offtopic, but this argument is exactly what I'm trying to tell Sakari when reviewing some other series. -- With Best Regards, Andy Shevchenko
