On Tue, Jan 24, 2023 at 04:03:55PM +0530, Shyam Sundar S K wrote: > On 1/24/2023 3:59 PM, Andy Shevchenko wrote: > > On Tue, Jan 24, 2023 at 12:27:37PM +0200, Andy Shevchenko wrote: > >> On Tue, Jan 24, 2023 at 03:36:50PM +0530, Shyam Sundar S K wrote: ... > >>> + u32 ic_con; > > > > One more nit-pick: > > > > unsigned int ic_con; > > is u32 not typedef of unsigned int? You should not care about implementation details. You call an API that uses unsigned int, why not using the correct type from the beginning? > > to be same as regmap_read() uses. -- With Best Regards, Andy Shevchenko