On Wed, Dec 21, 2022 at 08:51:15PM +0000, Hanna Hawa wrote: > Add an API to get the pinctrl pins if it was initialized before driver > probed. This API will be used in I2C core to get the device pinctrl > information for recovery state change. ... > /* The device core acts as a consumer toward pinctrl */ > +#include <linux/device.h> It's slightly misplaced. The comment above is for the below inclusion. > #include <linux/pinctrl/consumer.h> Can we make it ----8<---- #include <linux/device.h> /* The device core acts as a consumer toward pinctrl */ #include <linux/pinctrl/consumer.h> ----8<---- ? With this addressed, Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> -- With Best Regards, Andy Shevchenko