On Wed, Dec 07, 2022 at 03:10:43PM +0800, Binbin Zhou wrote: > 在 2022/12/6 23:13, Andy Shevchenko 写道: > > On Tue, Dec 06, 2022 at 11:16:54AM +0800, Binbin Zhou wrote: ... > > > -#include <linux/of.h> > > Cool, but don't you need to add property.h? > > Get it, I should have been more careful, maybe I'm still not very sensitive > to header files. > > Now I'm still basically judging based on whether I compile with errors or > not. You can generate the include tree by running `make includecheck` The rule of thumb is to include what you are the direct user of. With a few exceptions where we have the guarantees that one header is always included by another (e.g. bits.h included by bitops.h). > > Otherwise looks good to me. -- With Best Regards, Andy Shevchenko
