Re: [PATCH V3 2/5] i2c: gpio: Add support on ACPI-based system

[Binbin Zhou <zhoubinbin@xxxxxxxxxxx>]

在 2022/11/25 18:23, Andy Shevchenko 写道:
> On Fri, Nov 25, 2022 at 04:54:12PM +0800, Binbin Zhou wrote:
> > Add support for the ACPI-based device registration, so that the driver
> > can be also enabled through ACPI table.
> ...
>
> > +/* get i2c-gpio props from DT or ACPI table */
> Get
>
> ...
>
> > -	if (np) {
> > -		of_i2c_gpio_get_props(np, pdata);
> > +	if (np || has_acpi_companion(dev)) {
> > +		i2c_gpio_get_props(dev, pdata);
> 	if (dev_fwnode() {
> 		i2c_gpio_get_props(dev, pdata);
>
> ...
>
> > +	{"LOON0005", 0}, /*LoongArch*/
> ", 0" part is redundant. Also missing spaces in the comment.
Hi Andy:

Thanks for your review. I will fix them in the V4 patchset.

Binbin