Re: [PATCH] i2c: imx: use devm_platform_get_and_ioremap_resource()

[Mukesh Ojha <quic_mojha@xxxxxxxxxxx>]

Hi,

On 11/10/2022 2:53 PM, ye.xingchen@xxxxxxxxxx wrote:
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
> ---
>   drivers/i2c/busses/i2c-imx.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 3082183bd66a..1ce0cf7a323f 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1449,8 +1449,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
>   	if (irq < 0)
>   		return irq;
>
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(&pdev->dev, res);
> +	base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>   	if (IS_ERR(base))
>   		return PTR_ERR(base);

LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx>

_Mukesh