On Fri, Nov 04, 2022 at 05:26:24PM +0200, Tomi Valkeinen wrote: > On 04/11/2022 14:38, Andy Shevchenko wrote: > > On Fri, Nov 04, 2022 at 01:59:06PM +0200, Tomi Valkeinen wrote: > > > On 01/11/2022 16:30, Andy Shevchenko wrote: > > > > On Tue, Nov 01, 2022 at 03:20:26PM +0200, Tomi Valkeinen wrote: ... > > > > > + WARN(sysfs_create_link(&chan->adap.dev.kobj, &dev->kobj, "atr_device"), > > > > > + "can't create symlink to atr device\n"); > > > > > + WARN(sysfs_create_link(&dev->kobj, &chan->adap.dev.kobj, symlink_name), > > > > > + "can't create symlink for channel %u\n", chan_id); > > > > > > > > Why WARNs? sysfs has already some in their implementation. > > > > > > True, and I can drop these if required. But afaics, sysfs_create_link only > > > warns if there's a duplicate entry, not for other errors. > > > > The problem with WARN that it can be easily converted to real Oops. Do you > > consider other errors are so fatal that machine would need a reboot? > > Yes, WARNs are bad, especially as the error here is not critical. I'll > change these to dev_warn(). (also, I didn't know WARN could be made to > oops). panic_on_warn -- With Best Regards, Andy Shevchenko
