On Thu, 2022-11-03 at 13:16 +0100, Benjamin Tissoires wrote: > On Nov 02 2022, Randy Dunlap wrote: > > Hi-- > > > > [adding linux-input mailing list] > > > > On 10/25/22 00:39, Sven Zühlsdorf wrote: > > > Hi, > > > > > > I've run into two NULL pointer dereferences when loading the MCP2221 driver. > > > Initially I observed them running the kernel used by yocto kirkstone > > > (currently 5.15.68) but can reproduce them with a vanilla 6.1-rc1 as well. > > > All line numbers below are for hid-mcp2221.c, taken from 6.1-rc1. > > > > > > The first one was easy to identify, in mcp2221_probe line 874 `hdev->hidraw` > > > was NULL since I compiled the kernel without CONFIG_HIDRAW enabled. Should > > > CONFIG_HID_MCP2221 perhaps depend on or imply CONFIG_HIDRAW? > > > > Looks to me like it should. Hopefully the HID people can chime in here. > > I actually don't see why this driver (and hid-cp2112.c FWIW) should > depend on hidraw. To me, the reference to hidraw is just a nicer logging > message, but I have a hard time understanding how hidraw should be > involved in the driver, and if it were, how it could not break > everything. > > So IMO, we should probably change that line from the 2 drivers and > replace the hidraw part with the hid->id number which is unique. Exactly. See also https://lore.kernel.org/linux-input/20220926202239.16379-2-Enrik.Berkhan@xxxxxxx/ Cheers, Enrik
