On Tue, Nov 01, 2022 at 04:07:27PM +0800, Weilong Chen wrote: > The HiSilicon I2C controller can be used on embedded platform, which > boot from devicetree. Thanks, This version LGTM, Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Signed-off-by: Weilong Chen <chenweilong@xxxxxxxxxx> > Acked-by: Yicong Yang <yangyicong@xxxxxxxxxxxxx> > --- > Change since v9: > - Drop wrong use ACPI_PTR/of_match_ptr > Link: https://lore.kernel.org/lkml/dfc1c006-61c0-8f28-6164-060347c69d04@xxxxxxxxxx/T/ > > drivers/i2c/busses/Kconfig | 2 +- > drivers/i2c/busses/i2c-hisi.c | 7 +++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index e50f9603d189..a7bfddf08fa7 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -673,7 +673,7 @@ config I2C_HIGHLANDER > > config I2C_HISI > tristate "HiSilicon I2C controller" > - depends on (ARM64 && ACPI) || COMPILE_TEST > + depends on ARM64 || COMPILE_TEST > help > Say Y here if you want to have Hisilicon I2C controller support > available on the Kunpeng Server. > diff --git a/drivers/i2c/busses/i2c-hisi.c b/drivers/i2c/busses/i2c-hisi.c > index 76c3d8f6fc3c..bcc97e4fcb65 100644 > --- a/drivers/i2c/busses/i2c-hisi.c > +++ b/drivers/i2c/busses/i2c-hisi.c > @@ -489,11 +489,18 @@ static const struct acpi_device_id hisi_i2c_acpi_ids[] = { > }; > MODULE_DEVICE_TABLE(acpi, hisi_i2c_acpi_ids); > > +static const struct of_device_id hisi_i2c_dts_ids[] = { > + { .compatible = "hisilicon,ascend910-i2c", }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, hisi_i2c_dts_ids); > + > static struct platform_driver hisi_i2c_driver = { > .probe = hisi_i2c_probe, > .driver = { > .name = "hisi-i2c", > .acpi_match_table = hisi_i2c_acpi_ids, > + .of_match_table = hisi_i2c_dts_ids, > }, > }; > module_platform_driver(hisi_i2c_driver); > -- > 2.31.GIT > -- With Best Regards, Andy Shevchenko
