On Wed, Oct 26, 2022 at 03:39:01PM +0300, Jarkko Nikula wrote: > Hi > > I discovered recently while doing other cleanups.that reads and writes > from I2C bus to i2c-designware-slave.c don't work correctly. > > First two patches are fixes to slave code and meant for normal development > cycle since it looks these issues have been always here. > > I Cc'ed Michael Wu <michael.wu@xxxxxxxxxx> who has fixed > i2c-designware-slave.c before and Tian Ye <tianye@xxxxxxxxx> who recently > reported a write issue. > > Could you test first two patches (or the whole set) that my patches won't > cause regressions to your existing test cases or does the 2nd patch fix > the write issue? > > Rest of patches are minor changes and cleanups to both master and slave > parts. > Patchset is done on top of commit fd142e074e89 ("Merge branch > 'i2c/for-current-fixed' into i2c/for-next") but may apply on top of > v6.1-rc1 too. Side note, using --base in `git-format-patch --cover-letter` will help a lot (esp. CIs that take it into consideration). -- With Best Regards, Andy Shevchenko