On 2022/10/18 15:30, Weilong Chen wrote: > Add the new compatible for HiSilicon i2c. > > Signed-off-by: Weilong Chen <chenweilong@xxxxxxxxxx> > --- > Change since v5: > - Use hisilicon,i2c-ascend910 as compatible string. For more information about > the SoC at https://e.huawei.com/en/products/cloud-computing-dc/atlas/ascend-910 > - Alphabetic order the MAINTAINERS > > Change since v4: > - Add description for SoC specific compatibles. > - Use the clock binding. > - Fix decimal, space, case, unused labels. > Link: https://lore.kernel.org/lkml/20220909074842.281232-1-chenweilong@xxxxxxxxxx/T/#m4e1c915ead04f4e2e48d69131053a966801625db > > .../bindings/i2c/hisilicon,i2c-xxx.yaml | 70 +++++++++++++++++++ The file name may look a bit strange, but anyway the doc itself looks good to me. Reviewed-by: Yicong Yang <yangyicong@xxxxxxxxxxxxx> > MAINTAINERS | 1 + > 2 files changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/hisilicon,i2c-xxx.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/hisilicon,i2c-xxx.yaml b/Documentation/devicetree/bindings/i2c/hisilicon,i2c-xxx.yaml > new file mode 100644 > index 000000000000..a7285ddc260d > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/hisilicon,i2c-xxx.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/i2c/hisilicon,i2c-xxx.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > + > +title: HiSilicon common IIC controller Device Tree Bindings > + > +maintainers: > + - yangyicong@xxxxxxxxxx > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + const: hisilicon,i2c-ascend910 > + description: > + The HiSilicon common IIC controller can be used for many different > + types of SoC such as Huawei Ascend AI series chips. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-frequency: > + default: 400000 > + > + i2c-sda-falling-time-ns: > + default: 343 > + > + i2c-scl-falling-time-ns: > + default: 203 > + > + i2c-sda-hold-time-ns: > + default: 830 > + > + i2c-scl-rising-time-ns: > + default: 365 > + > + i2c-digital-filter-width-ns: > + default: 0 > + > +required: > + - compatible > + - reg > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c@5038b0000 { > + compatible = "hisilicon,i2c-ascend910"; > + reg = <0x38b0000 0x10000>; > + interrupts = <0x0 120 0x4>; > + i2c-sda-falling-time-ns = <56>; > + i2c-scl-falling-time-ns = <56>; > + i2c-sda-hold-time-ns = <56>; > + i2c-scl-rising-time-ns = <56>; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <0x0>; > + clocks = <&alg_clk>; > + clock-frequency = <400000>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index ad32dc9c4822..961e4442fb08 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9211,6 +9211,7 @@ M: Yicong Yang <yangyicong@xxxxxxxxxxxxx> > L: linux-i2c@xxxxxxxxxxxxxxx > S: Maintained > W: https://www.hisilicon.com > +F: Documentation/devicetree/bindings/i2c/hisilicon,i2c-xxx.yaml > F: drivers/i2c/busses/i2c-hisi.c > > HISILICON LPC BUS DRIVER >
