On Mon, Sep 26, 2022, at 4:59 PM, Mika Westerberg wrote:
>> +static void acpi_i2c_gpio_get_props(struct device *dev,
>> + struct i2c_gpio_platform_data *pdata)
>> +{
>> + u32 reg;
>> +
>> + device_property_read_u32(dev, "delay-us", &pdata->udelay);
>> +
>> + if (!device_property_read_u32(dev, "timeout-ms", ®))
>> + pdata->timeout = msecs_to_jiffies(reg);
>> +
>> + pdata->sda_is_open_drain =
>> + device_property_read_bool(dev, "sda-open-drain");
>> + pdata->scl_is_open_drain =
>> + device_property_read_bool(dev, "scl-open-drain");
>> + pdata->scl_is_output_only =
>> + device_property_read_bool(dev, "scl-output-only");
>> +}
>
> Otherwise this patch looks good but I'm concerned because we have two
> kinds of bindings now. The DT one above uses "i2c-gpio,..." and this
> ACPI one uses just "..." so the question is where did these come from?
> Is there already some existing system out there with these bindings or
> they are documented somewhere?
I'm fairly sure it's just a mistake and it should use the regular
binding. As far as I understand, there are still other incompatible
changes being made to the firmware on these machines, so it's just
a matter of updating this part as well.
Arnd
