Hi, On Fri, Sep 23, 2022 at 03:16:03PM +0800, Huacai Chen wrote: > Hi, Mika, > > On Thu, Sep 22, 2022 at 8:23 PM Mika Westerberg > <mika.westerberg@xxxxxxxxxxxxxxx> wrote: > > > > Hi, > > > > On Thu, Sep 22, 2022 at 07:39:54PM +0800, Binbin Zhou wrote: > > > Under LoongARCH based on ACPI(such as Loongson-3A + LS7A), the ls2x i2c > > > driver obtains the i2c bus number from ACPI table. > > > > Why this is needed? The I2CSerialBusV2() resource should be enough to > > identify the adapter, and I don't see why static number would be needed > > for anything? > > > In later patches we will add LS7A i2c driver, this driver is shared by > MIPS-based Loongson-3A4000 system (use FDT) and LoongArch-based > Loongson-3A5000 system (use ACPI). > > FDT systems support static bus numbers, so we want to do the same > thing on ACPI systems. I think keep this consistency can make user > feel better I don't think the user cares to be honest. As long as all the devices work as expected ;-) And this saves a couple of lines of code too so if not really needed, I would just drop that part.
