Hi Binbin, Thank you for the patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on linus/master v6.0-rc6 next-20220921] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Binbin-Zhou/i2c-ls2x-Add-support-for-the-Loongson-2K-LS7A-I2C/20220922-194252 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20220923/202209231036.KnY4wKcL-lkp@xxxxxxxxx/config) compiler: s390-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/df754cf9cc58fc815223d6126fa1c86717cd3465 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Binbin-Zhou/i2c-ls2x-Add-support-for-the-Loongson-2K-LS7A-I2C/20220922-194252 git checkout df754cf9cc58fc815223d6126fa1c86717cd3465 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/i2c/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/i2c/busses/i2c-ls2x.c: In function 'i2c_stop': >> drivers/i2c/busses/i2c-ls2x.c:45:33: error: implicit declaration of function 'writeb' [-Werror=implicit-function-declaration] 45 | #define i2c_writeb(val, addr) writeb(val, dev->base + addr) | ^~~~~~ drivers/i2c/busses/i2c-ls2x.c:60:9: note: in expansion of macro 'i2c_writeb' 60 | i2c_writeb(LS2X_I2C_CMD_STOP, LS2X_I2C_CR_REG); | ^~~~~~~~~~ >> drivers/i2c/busses/i2c-ls2x.c:44:33: error: implicit declaration of function 'readb' [-Werror=implicit-function-declaration] 44 | #define i2c_readb(addr) readb(dev->base + addr) | ^~~~~ drivers/i2c/busses/i2c-ls2x.c:63:9: note: in expansion of macro 'i2c_readb' 63 | i2c_readb(LS2X_I2C_SR_REG); | ^~~~~~~~~ cc1: some warnings being treated as errors vim +/writeb +45 drivers/i2c/busses/i2c-ls2x.c 43 > 44 #define i2c_readb(addr) readb(dev->base + addr) > 45 #define i2c_writeb(val, addr) writeb(val, dev->base + addr) 46 -- 0-DAY CI Kernel Test Service https://01.org/lkp
