> > The new variable makes it more readable, but beyond that, do you see any > > reason not to just directly compose the calls? > > > > You could do that too. > > You pointed this out in your other email but the one thing that people > have to be careful of when assigning struct_size() is that the > "mux_size" variable has to be size_t. > > The math in submit_create() from drivers/gpu/drm/msm/msm_gem_submit.c > is so terribly unreadable. It works but it's so ugly. Unfortunately, > I'm the person who wrote it. I can't parse from that if the patch in question is okay or needs a respin? Could you kindly enlighten me?
Attachment:
signature.asc
Description: PGP signature
