On Wed, Sep 14, 2022 at 03:34:24PM +0200, Jean Delvare wrote:
> Hi Adam,
>
> On Wed, 7 Sep 2022 02:06:51 +0000, Adam Honse wrote:
> > This patch introduces a new driver for the SMBus adapter that is built in
> > to most Nuvoton Super-IO chips. This SMBus adapter is used for RGB
> > lighting control on some ASUS motherboards with Intel chipsets.
> >
> > The interface's register description is available in the supported
> > devices' datasheets. Operation of this interface has been verified
> > with OpenRGB on an ASUS PRIME Z270-A motherboard.
>
> Care to point me to one such datasheet?
>
> The following errors are reported by ./scripts/checkpatch.pl (which I
> invite you to run before posting any patch):
>
> RROR: "foo * bar" should be "foo *bar"
> #452: FILE: drivers/i2c/busses/i2c-nct6793.c:295:
> +static struct i2c_adapter * nct6793_add_adapter(unsigned short smba, const char *name)
>
> ERROR: trailing whitespace
> #526: FILE: drivers/i2c/busses/i2c-nct6793.c:369:
> +^I^I$
>
> ERROR: space required before the open parenthesis '('
> #527: FILE: drivers/i2c/busses/i2c-nct6793.c:370:
> + if(IS_ERR(sio_data->adapter))
>
> Please fix before resubmitting.
>
> Also, would you consider declaring yourself the maintainer of this new
> driver? If so, please add a new entry in MAINTAINERS and add yourself
> there. You can use the "I2C/SMBUS ISMT DRIVER" entry as an example.
>
> If not, no worry, I'll add the driver to my own list.
>
> I see that there already seem to be a driver for the SMBus interface of
> Novoton Super-I/O chipsets:
>
> drivers/hwmon/nct6775-i2c.c
>
> However that driver seems to be fairly limited in capabilities (on
> purpose). I'm adding the author of this driver and the maintainer of the
> hwmon subsystem to Cc. How do the two drivers relate to each other? Are
> they for the same, or different interfaces? If different, we need to
> come up with names to designate them unambiguously. If the same, then
> I'm afraid both drivers will step on each other's toes?
>
That driver connects to the I2C slave interface on Nuvoton chips.
The driver here implements support for its I2C master. The driver here
talks to the master interface on the chip through superio, and is
typically connected to the main processor on a system. The other driver
is an I2C slave driver. The slave interface on NCT chips is normally
connected to a BMC.
The i/o address by this driver uses a different base address register
than its hwmon platform driver (which also connects to the chip
through superio), so this driver should hopefully be able to
interoperate with that driver. It would be desirable to confirm that
the two drivers do not step on each other, though (especially since the
sio register page is the same).
Thanks,
Guenter
