On Fri, Sep 09, 2022 at 03:48:42PM +0800, Weilong Chen wrote: > Add the new compatible for HiSilicon common i2c. > > Signed-off-by: Weilong Chen <chenweilong@xxxxxxxxxx> > --- > .../bindings/i2c/hisilicon,hisi-i2c.yaml | 67 +++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/hisilicon,hisi-i2c.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/hisilicon,hisi-i2c.yaml b/Documentation/devicetree/bindings/i2c/hisilicon,hisi-i2c.yaml > new file mode 100644 > index 000000000000..f1cb6a4c70d1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/hisilicon,hisi-i2c.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/i2c/hisilicon,hisi-i2c.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > + > +title: HiSilicon common IIC controller Device Tree Bindings > + > +maintainers: > + - yangyicong@xxxxxxxxxx > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + const: hisilicon,hisi-i2c You need SoC specific compatibles. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clk_rate: > + default: 0xEE6B280 What is this property for? Use the clock binding. > + > + clock-frequency: > + default: 400000 > + > + i2c-sda-falling-time-ns: > + default: 343 > + > + i2c-scl-falling-time-ns: > + default: 203 > + > + i2c-sda-hold-time-ns: > + default: 0x33E The rest are in decimal. Be consistent. > + > + i2c-scl-rising-time-ns: > + default: 365 > + > + i2c-digital-filter-width-ns: > + default: 0 > + > +required: > + - compatible > + - reg > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c1: i2c@5038B0000{ Space needed ^ Use lowercase hex. Drop unused labels. > + compatible = "hisilicon,hisi-i2c"; > + reg = <0x38B0000 0x10000>; > + interrupts = <0x0 120 0x4>; > + i2c-sda-falling-time-ns = <56>; > + i2c-scl-falling-time-ns = <56>; > + i2c-sda-hold-time-ns = <56>; > + i2c-scl-rising-time-ns = <56>; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <0x0>; > + clk_rate = <0x0 0xEE6B280>; > + clock-frequency = <400000>; > + }; > -- > 2.31.GIT > >
