Re: [PATCH v3 1/1] i2c: scmi: Replace open coded device_get_match_data()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/25/22 17:14, Andy Shevchenko wrote:
On Tue, Aug 16, 2022 at 08:03:33AM +0200, Josef Johansson wrote:
On 7/8/22 14:09, Andy Shevchenko wrote:
I tried build Linux 6.0 and run under Xen 4.14.5. I got a kernel null pointer dereferenced while booting. Reverting this commit allowed the system to boot.

Since I do not have any way of capturing the error except camera (it's a long message), here's my best try.

BUG: kernel NULL pointer dereference, address: 0000000000000000
I think I know what happens there. Can you test a hackpatch (below)
with my patch _not being reverted_?

diff --git a/drivers/i2c/busses/i2c-scmi.c b/drivers/i2c/busses/i2c-scmi.c
index 79798fc7462a..3ed1758706b0 100644
--- a/drivers/i2c/busses/i2c-scmi.c
+++ b/drivers/i2c/busses/i2c-scmi.c
@@ -426,6 +426,9 @@ static struct acpi_driver acpi_smbus_cmi_driver = {
  		.add = acpi_smbus_cmi_add,
  		.remove = acpi_smbus_cmi_remove,
  	},
+	.drv = {
+		.acpi_match_table = acpi_smbus_cmi_ids,
+	},
  };
  module_acpi_driver(acpi_smbus_cmi_driver);
Hi,

I applied your patch and the system boots now. Good job :)

Regards
- Josef



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux