Re: [PATCH v2 6/6] i2c: Make remove callback return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 15, 2022 at 10:02:30AM +0200, Uwe Kleine-König wrote:
> The value returned by an i2c driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
> 
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
> 
> Reviewed-by: Peter Senna Tschudin <peter.senna@xxxxxxxxx>
> Reviewed-by: Jeremy Kerr <jk@xxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx>
> Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> Reviewed-by: Crt Mori <cmo@xxxxxxxxxxx>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Acked-by: Marek Behún <kabel@xxxxxxxxxx> # for leds-turris-omnia
> Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Reviewed-by: Petr Machata <petrm@xxxxxxxxxx> # for mlxsw
> Reviewed-by: Maximilian Luz <luzmaximilian@xxxxxxxxx> # for surface3_power
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> # for bmc150-accel-i2c + kxcjk-1013
> Reviewed-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> # for media/* + staging/media/*
> Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx> # for auxdisplay/ht16k33 + auxdisplay/lcd2s
> Reviewed-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx> # for versaclock5
> Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> # for versaclock5
> Reviewed-by: Ajay Gupta <ajayg@xxxxxxxxxx> # for ucsi_ccg
> Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> # for iio
> Acked-by: Peter Rosin <peda@xxxxxxxxxx> # for i2c-mux-*, max9860
> Acked-by: Adrien Grassein <adrien.grassein@xxxxxxxxx> # for lontium-lt8912b
> Reviewed-by: Jean Delvare <jdelvare@xxxxxxx> # for hwmon, i2c-core and i2c/muxes
> Acked-by: Corey Minyard <cninyard@xxxxxxxxxx> # for IPMI
> Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Acked-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> # for drivers/power
> Acked-by: Krzysztof Hałasa <khalasa@xxxxxxx>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Applied to an immutable branch, thanks!

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux