Hi Wolfram, On 22 July 2022 17:07 Wolfram Sang wrote > > Yet another i2c controller from Renesas that is found on the RZ/V2M > > (r9a09g011) SoC. It can support only 100kHz and 400KHz operation. > > Geez, you are right with "yet another". One wonders why the 5 others are > not enough? Quite... > > +static int rzv2m_i2c_master_xfer1(struct rzv2m_i2c_priv *priv, > > + struct i2c_msg *msg, int stop) > > I'd prefer "rzv2m_i2c_master_xfer_msg" for this function.s > > > + adap->class = I2C_CLASS_DEPRECATED; > > You don't need to set the class to deprecated because there can't be a > previous version which now loses this functionality and needs to inform > userspace about it. .class can be 0 here. Ok > Reset looks looks, good thanks! > > I can fix up these minor things when applying if you don't mind. Thanks! Phil