On Wed, Jul 06, 2022 at 03:06:42PM +0200, Wolfram Sang wrote:
> On Sun, Jul 03, 2022 at 06:42:32PM +0300, Andy Shevchenko wrote:
> > str_read_write() returns a string literal "read" or "write" based
> > on the value. It also allows to unify usage of a such in the kernel.
> >
> > For i2c case introduce a wrapper that takes struct i2c_msg as parameter.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> To be honest, I don't think this series is very useful. Most of the
> converted strings here are debug printouts which could rather be removed
> because we have a tracepoint for i2c_transfer (which is the preferred
> unification).
OK.
> The warnings printed on timeouts are plain wrong, because
> timeouts can happen and need to be handled by the client driver.
OK
> And the
> change in the I2C core is not worth the hazzle IMHO.
OK
Just noticed yet another (but not in the category of the above) debug message
[1]. Would it be acceptable to use patch 1 from this series and its use in (a
completely new) patch 2?
[1]: i2c-scmi.c:
dev_dbg(&adap->dev, "access size: %d %s\n", size,
(read_write) ? "READ" : "WRITE");
--
With Best Regards,
Andy Shevchenko
