Re: [PATCH v3 4/4] riscv: dts: sifive: "fix" pmic watchdog node name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/06/2022 16:58, Conor.Dooley@xxxxxxxxxxxxx wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> A ping and an offer:
> 
> Palmer, do you want me to take the random dt cleanups through
> my tree & save you the hassle of following along with them?

Since you declined that offer & nothing's been heard from the
SiFive side since - I think this should also be good to take
for 5.20. The bindings etc have already been applied.
Thanks,
Conor.

> 
> Thanks,
> Conor.
> 
> On 13/06/2022 15:05, Heiko Stübner wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> Am Montag, 13. Juni 2022, 15:33:49 CEST schrieb Conor.Dooley@xxxxxxxxxxxxx:
>>>
>>> On 06/06/2022 21:13, Conor Dooley wrote:
>>>> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>>>>
>>>> After converting the pmic watchdog binding to yaml, dtbs_check complains
>>>> that the node name doesn't match the binding. "Fix" it.
>>>
>>> Hey Palmer,
>>> The three dt-binding changes were accepted - do I need to poke SiFive to
>>> ack the dts change or are you fine just taking it?
>>
>> I don't think a node-name has relevance to vendor decisions ;-) .
>>
>> Looking at bindings/watchdog/watchdog.yaml we clearly see that
>> the node name is always watchdog or watchdog@foo, so this change
>> is clearly correct.
>>
>> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
>>
>>
>>> Thanks,
>>> Conor.
>>>
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>>> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>>>> ---
>>>>   arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>>>> index c4ed9efdff03..1f386b07a832 100644
>>>> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>>>> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
>>>> @@ -90,7 +90,7 @@ rtc {
>>>>                     compatible = "dlg,da9063-rtc";
>>>>             };
>>>>
>>>> -           wdt {
>>>> +           watchdog {
>>>>                     compatible = "dlg,da9063-watchdog";
>>>>             };
>>>>
>>> _______________________________________________
>>> linux-riscv mailing list
>>> linux-riscv@xxxxxxxxxxxxxxxxxxx
>>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>>>
>>
>>
>>
>>
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-riscv





[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux