Re: [PATCH 5/6] gpio: pca953x: Make platform teardown callback return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 28, 2022 at 09:09:09PM +0200, Andy Shevchenko wrote:
> On Tue, Jun 28, 2022 at 4:04 PM Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> >
> > All platforms that provide a teardown callback return 0. New users are
> > supposed to not make use of platform support, so there is no
> > functionality lost.
> >
> > This patch is a preparation for making i2c remove callbacks return void.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > Forwarded: id:20220502170555.51183-1-u.kleine-koenig@xxxxxxxxxxxxxx
> 
> What is this tag for? Has it been documented?

No, this is a note to myself and wasn't intended to be sent out.

> However, I prefer to see dropping those callbacks altogether (find the
> way how to use GPIO descriptors / GPIO table / etc instead of ugly
> custom callbacks).

Agreed, but I didn't feel to sort out what happens there. Also I don't
have any of these platforms to test. So I chose the more conservative
approach.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux