Re: [bug report] kmemleak from driver i2c_piix4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jean,

My testing shows this patch fixes the issue. I recreated the leak issue using 
v5.19.0-rc2 without this patch. I added this patch, retested using kmemleak, 
and the problem was not created. 

Patch inspection shows this fix properly frees the memoru resource structure.

You may add my 'tested-by' and/or 'reviewed-by'.

Regards,
Terry


On 6/22/22 01:39, Jean Delvare wrote:
> Hi Terry,
> 
> On Tue, 21 Jun 2022 09:29:44 -0500, Terry Bowman wrote:
>> On 6/21/22 07:48, Jean Delvare wrote:
>>
>>> Yi Zhang, can you please test this patch and confirm that it solves the
>>> memory leak?
>>>
>>> Terry, please review/comment.
>>>
>>> If my analysis is correct then the sp5100_wdt and thinkpad_acpi drivers
>>> suffer from a similar leak and need to be fixed the same way.
>>
>> Your analysis is correct. The kfree() call is missing during the release in i2c-piix4 and 
>> sp5100_tco driver patches. Let me know if there is anything I can do.
> 
> I've submitted patches for the 3 drivers. They are pretty
> straightforward, but anything you'd be able to review or test would be
> welcome.
> 
> Thanks,



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux