Wolfram Sang <wsa@xxxxxxxxxx> writes: > On Fri, Mar 25, 2022 at 01:06:25PM -0500, Chris Morgan wrote: >> From: Chris Morgan <macromorgan@xxxxxxxxxxx> >> >> When I attempt to shut down (or reboot) my R8 based NTC CHIP with this >> i2c driver I get the following error: "i2c i2c-0: mv64xxx: I2C bus >> locked, block: 1, time_left: 0". Reboots are successful but shutdowns >> freeze. If I comment out the shutdown routine the device both reboots >> and shuts down successfully without receiving this error (however it >> does receive a warning of missing atomic_xfer). >> >> It appears that very few i2c drivers have a shutdown method, I assume >> because these devices are often used to communicate with PMICs (such >> as in my case with the R8 based NTC CHIP). I'm proposing we simply >> remove this method so long as it doesn't cause trouble for others >> downstream. I'll work on an atomic_xfer method and submit that in >> a different patch. >> >> Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx> > > Gregory? Looks reasonable to me. Acked-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> Thanks, Gregory -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
