On 06/05/2022 14:26, Yihao Han wrote: > Since ret is a redundant variable, and none of the callers check > for return, so remove ret variable and change return type of > 'i2c_s3c_irq_nextbyte' from 'int' to 'void' > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Signed-off-by: Yihao Han <hanyihao@xxxxxxxx> > --- > v2: add return in STATE_IDLE case > --- > drivers/i2c/busses/i2c-s3c2410.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c > index b49a1b170bb2..d2a1fd2aa7a0 100644 > --- a/drivers/i2c/busses/i2c-s3c2410.c > +++ b/drivers/i2c/busses/i2c-s3c2410.c > @@ -381,17 +381,16 @@ static inline int is_msgend(struct s3c24xx_i2c *i2c) > /* > * process an interrupt and work out what to do > */ > -static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) > +static void i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) This still should not compile... are you sure you run all the checks on it? Please do not cc non-working addresses (kernel@vivo). Best regards, Krzysztof
