On Sat, 23 Apr 2022 10:30:53 +0100,
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 22/04/2022 12:45, Krzysztof Kozlowski wrote:
> > The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.
> >
> > Fixes: f48e699ddf70 ("irqchip/aspeed-i2c-ic: Add I2C IRQ controller for Aspeed")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > ---
> > drivers/irqchip/irq-aspeed-i2c-ic.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/irqchip/irq-aspeed-i2c-ic.c b/drivers/irqchip/irq-aspeed-i2c-ic.c
> > index a47db16ff960..cef1291ae783 100644
> > --- a/drivers/irqchip/irq-aspeed-i2c-ic.c
> > +++ b/drivers/irqchip/irq-aspeed-i2c-ic.c
> > @@ -77,7 +77,7 @@ static int __init aspeed_i2c_ic_of_init(struct device_node *node,
> > }
> >
> > i2c_ic->parent_irq = irq_of_parse_and_map(node, 0);
> > - if (i2c_ic->parent_irq < 0) {
> > + if (!i2c_ic->parent_irq) {
> > ret = i2c_ic->parent_irq;
>
> This is wrong (same in patch 2). I will send a v2.
While you're at it, please add a cover letter when sending a series
containing more than a single patch.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
