On Mon, Apr 18, 2022 at 1:08 PM <cgel.zte@xxxxxxxxx> wrote:
>
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
>
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
>
The commit subject should be "eeprom: at24: ..." and the commit
message is missing the *why* for this change. Otherwise looks good.
Bart
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
> ---
> drivers/misc/eeprom/at24.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index 633e1cf08d6e..0a5bdd629427 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -431,11 +431,9 @@ static int at24_read(void *priv, unsigned int off, void *val, size_t count)
> if (off + count > at24->byte_len)
> return -EINVAL;
>
> - ret = pm_runtime_get_sync(dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(dev);
> + ret = pm_runtime_resume_and_get(dev);
> + if (ret < 0)
> return ret;
> - }
>
> /*
> * Read data from chip, protecting against concurrent updates
> @@ -478,11 +476,9 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count)
> if (off + count > at24->byte_len)
> return -EINVAL;
>
> - ret = pm_runtime_get_sync(dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(dev);
> + ret = pm_runtime_resume_and_get(dev);
> + if (ret < 0)
> return ret;
> - }
>
> /*
> * Write data to chip, protecting against concurrent updates
> --
> 2.25.1
>
>
