On Sat, Mar 26, 2022 at 12:58:36PM -0700, Linus Torvalds wrote: > On Fri, Mar 25, 2022 at 1:28 AM Wolfram Sang <wsa@xxxxxxxxxx> wrote: > > > > I2C has for 5.18: tracepoints when Linux acts as an I2C client, added > > support for AMD PSP, whole subsytsem now uses generic_handle_irq_safe(), > > piix4 driver gained MMIO access enabling so far missed controllers with > > AMD chipsets, plus a bulk of device driver updates, refactorization, and > > fixes. > > It feels odd/wrong to use the piix4 driver for the AMD MMIO case on SB800. > > Would it not have made more sense to just make that a separate driver? > > It feels like now the piix4 driver has a lot of "if SB800" for the > probing code, and then a lot of "if (mmio)" at runtime. > > I've pulled this, but just wanted to mention this "that looks a bit > odd". How much code is actually _shared_ in the SB800 case? > > I'm not insisting on splitting this up - maybe it all makes sense. I'm > just questioning it. Adding Jean to CC, he maintains the PC-style drivers.
Attachment:
signature.asc
Description: PGP signature
