On Fri, 18 Mar 2022 11:53:48 +0100 Wolfram Sang <wsa@xxxxxxxxxx> wrote: > > trace printings can be selected by adding a filter like: > > > > echo adapter_nr==1 >/sys/kernel/tracing/events/i2c_slave/filter > > > > Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@xxxxxxxxxxx> > > Steven, are you happy with the tracepoint parts of this patch? Strange. I do not have v2 in my inbox anywhere. I checked the spam folders and found nothing. I had a glitch in my mail server around this time and maybe it was dropped then. Let me take a look at it in my LMKL folder, which it appears to be there :-/ -- Steve > > > > + if (trace_i2c_slave_enabled() && !ret) > > + trace_i2c_slave(client, event, val); > > Why '!ret'? I think we should always print 'ret' in the trace as well. > Backends are allowed to send errnos on WRITE_RECEIVED to NACK the > reception of a byte. This is useful information, too, or? > > Rest looks good to me. > > Thanks, > > Wolfram >
