wt., 1 mar 2022 o 16:16 Wolfram Sang <wsa@xxxxxxxxxx> napisał(a): > > On Fri, Feb 18, 2022 at 02:33:48PM +0100, Jan Dabros wrote: > > Kernel test robot reported incorrect type in argument 1 of readl(), but > > more importantly it brought attention that MMIO accessor shouldn't be > > used in this case, since req->hdr.status is part of a command-response > > buffer in system memory. > > > > Since its value may be altered by PSP outside of the scope of current > > thread (somehow similar to IRQ handler case), we need to use > > READ_ONCE() to ensure compiler won't optimize this call. > > > > Fix also 'status' variable type to reflect that corresponding field in > > command-response buffer is platform-independent u32. > > > > Signed-off-by: Jan Dabros <jsd@xxxxxxxxxxxx> > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Applied to for-next, thanks! Thanks! > Jan, I wonder if you want to be the maintainer for this driver? If you'd > like, then please send me the patch adding you to MAINTAINERS. So, you > will get notified if people want to enhance this driver. So actually I've already added myself as a R:eviewer for i2c-designware-* files in one of the previous patches with the purpose of reviewing code touching this driver. This makes sense since I can also test modifications on my device. Best Regards, Jan
