Re: [PATCH 08/22] usb: gadget: lpc32xx_udc: Don't use GFP_DMA when calling dma_alloc_coherent()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 08/22] usb: gadget: lpc32xx_udc: Don't use GFP_DMA when calling dma_alloc_coherent()
From: Christoph Hellwig <hch@xxxxxx>
Date: Sat, 19 Feb 2022 08:09:05 +0100
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, hch@xxxxxx, cl@xxxxxxxxx, 42.hyeyoo@xxxxxxxxx, penberg@xxxxxxxxxx, rientjes@xxxxxxxxxx, iamjoonsoo.kim@xxxxxxx, vbabka@xxxxxxx, David.Laight@xxxxxxxxxx, david@xxxxxxxxxx, herbert@xxxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, steffen.klassert@xxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, hca@xxxxxxxxxxxxx, gor@xxxxxxxxxxxxx, agordeev@xxxxxxxxxxxxx, borntraeger@xxxxxxxxxxxxx, svens@xxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, michael@xxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, wsa@xxxxxxxxxx
In-reply-to: <20220219005221.634-9-bhe@redhat.com>
References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-9-bhe@redhat.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Sat, Feb 19, 2022 at 08:52:07AM +0800, Baoquan He wrote:
> dma_alloc_coherent() allocates dma buffer with device's addressing
> limitation in mind. It's redundent to specify GFP_DMA when calling
> dma_alloc_coherent().

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH 00/22] Don't use kmalloc() with GFP_DMA
  - From: Baoquan He
- [PATCH 08/22] usb: gadget: lpc32xx_udc: Don't use GFP_DMA when calling dma_alloc_coherent()
  - From: Baoquan He

Prev by Date: Re: [PATCH 07/22] fbdev: mx3fb: Don't use GFP_DMA when calling dma_alloc_wc()
Next by Date: Re: [PATCH 09/22] usb: cdns3: Don't use GFP_DMA when calling dma_alloc_coherent()
Previous by thread: [PATCH 08/22] usb: gadget: lpc32xx_udc: Don't use GFP_DMA when calling dma_alloc_coherent()
Next by thread: [PATCH 11/22] staging: emxx_udc: Don't use GFP_DMA when calling dma_alloc_coherent()
Index(es):
- Date
- Thread

[Index of Archives] [Linux GPIO] [Linux SPI] [Linux Hardward Monitoring] [LM Sensors] [Linux USB Devel] [Linux Media] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]