dma_alloc_coherent() allocates dma buffer with device's addressing limitation in mind. It's redundent to specify GFP_DMA when calling dma_alloc_coherent(). [ 42.hyeyoo@xxxxxxxxx: Update changelog ] Signed-off-by: Baoquan He <bhe@xxxxxxxxxx> Acked-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx> --- drivers/video/fbdev/da8xx-fb.c | 4 ++-- drivers/video/fbdev/fsl-diu-fb.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c index 005ac3c17aa1..7cb7e63117c9 100644 --- a/drivers/video/fbdev/da8xx-fb.c +++ b/drivers/video/fbdev/da8xx-fb.c @@ -1426,7 +1426,7 @@ static int fb_probe(struct platform_device *device) par->vram_virt = dmam_alloc_coherent(par->dev, par->vram_size, &par->vram_phys, - GFP_KERNEL | GFP_DMA); + GFP_KERNEL); if (!par->vram_virt) { dev_err(&device->dev, "GLCD: kmalloc for frame buffer failed\n"); @@ -1446,7 +1446,7 @@ static int fb_probe(struct platform_device *device) /* allocate palette buffer */ par->v_palette_base = dmam_alloc_coherent(par->dev, PALETTE_SIZE, &par->p_palette_base, - GFP_KERNEL | GFP_DMA); + GFP_KERNEL); if (!par->v_palette_base) { dev_err(&device->dev, "GLCD: kmalloc for palette buffer failed\n"); diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c index e332017c6af6..a79fa162a5d1 100644 --- a/drivers/video/fbdev/fsl-diu-fb.c +++ b/drivers/video/fbdev/fsl-diu-fb.c @@ -1692,7 +1692,7 @@ static int fsl_diu_probe(struct platform_device *pdev) int ret; data = dmam_alloc_coherent(&pdev->dev, sizeof(struct fsl_diu_data), - &dma_addr, GFP_DMA | __GFP_ZERO); + &dma_addr, __GFP_ZERO); if (!data) return -ENOMEM; data->dma_addr = dma_addr; -- 2.17.2