Hi Wolfram an Jean,
On 2/11/22 09:00, Terry Bowman wrote:
> Hi Wolfram and Jean,
>
> On 2/11/22 08:42, Wolfram Sang wrote:
>>>> + if (retval)
>>>
>>> Missing curly brace here, breaks the build.
>>
>> Bummer, need to check why this wasn't found by my build-testing.
>>
>> I fixed it up and also rebased patch 6 to my change. Terry, please have
>> a look that I did everything correctly once I push out later today.
>>
>> Thanks everyone!
>>
> I need to look at how I sent that out. I will look for the fix in
> i2c/for-next. Thanks for the help and review.
I verified the fix looks good. From commit a3325d225b00 on i2c/for-next:
@@ -373,11 +388,10 @@ static int piix4_setup_sb800(struct pci_dev *PIIX4_dev,
piix4_port_shift_sb800 = SB800_PIIX4_PORT_IDX_SHIFT;
}
} else {
- if (!request_muxed_region(SB800_PIIX4_SMB_IDX,
- SB800_PIIX4_SMB_MAP_SIZE,
- "sb800_piix4_smb")) {
+ retval = piix4_sb800_region_request(&PIIX4_dev->dev);
+ if (retval) {
release_region(piix4_smba, SMBIOSIZE);
- return -EBUSY;
+ return retval;
}
