Re: [PATCH v4 4/9] i2c: piix4: Move SMBus controller base address detect into function

[Jean Delvare <jdelvare@xxxxxxx>]

On Sun, 30 Jan 2022 12:41:25 -0600, Terry Bowman wrote:
>  static int piix4_setup_sb800(struct pci_dev *PIIX4_dev,
>  			     const struct pci_device_id *id, u8 aux)
>  {
> -	unsigned short piix4_smba;
> -	u8 smba_en_lo, smba_en_hi, smb_en, smb_en_status, port_sel;
> +	u8 smb_en, smb_en_status, port_sel;
>  	u8 i2ccfg, i2ccfg_offset = 0x10;
> +	unsigned short piix4_smba;
>  	int retval;
>  
>  	/* SB800 and later SMBus does not support forcing address */

I suggest not moving variables around unless there's a compelling to do
that. Else you make your patches larger (and slightly harder to
review), plus it increases the risks of context conflicts when
backporting other changes.

Thanks,
-- 
Jean Delvare
SUSE L3 Support