Hello again Samuel, On Sat, Jan 29, 2022 at 05:00:39PM -0600, Samuel Holland wrote: > The official Pine64 PinePhone keyboard case contains a matrix keypad and > a MCU which runs a libre firmware. Add support for its I2C interface. I had one bug report from a user that reminded me of something that's missing in the driver. Please add a regulator support for power supply for the keyboard. On Pinephone the keyboard needs USB-5V regulator to be enabled, because final version of the keyboard is supplied from the VBAT POGO pin and not internally from kb battery, as on the prototypes. If this regulator is not enabled the keyboard will be supplied from battery - voltage drop on a boost regulator diode, which causes very frequent brownouts of the keyboard MCU. Users don't notice, becuse MCU recovers quickly and only a key or two is missed every once in a while, but it should be fixed. And this problem probably only shows up when the phone battery is either quite discharged, or random load spikes push its voltage bellow what's necessary for the MCU to run, temporarily. kind regards, o.
