Hi Terry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on groeck-staging/hwmon-next] [also build test WARNING on linux/master linus/master v5.17-rc2 next-20220128] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Terry-Bowman/Watchdog-sp5100_tco-Replace-cd6h-cd7h-port-I-O-accesses-with-MMIO-accesses/20220131-031525 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next config: x86_64-randconfig-m001-20220131 (https://download.01.org/0day-ci/archive/20220131/202201311346.KLMS6idr-lkp@xxxxxxxxx/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/92f6f8c644fc7df3d1f3f8e32f8b1f4efc3f321f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Terry-Bowman/Watchdog-sp5100_tco-Replace-cd6h-cd7h-port-I-O-accesses-with-MMIO-accesses/20220131-031525 git checkout 92f6f8c644fc7df3d1f3f8e32f8b1f4efc3f321f # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/watchdog/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from include/linux/device.h:15, from include/linux/pci.h:37, from drivers/watchdog/sp5100_tco.c:40: drivers/watchdog/sp5100_tco.c: In function 'sp5100_tco_prepare_base': drivers/watchdog/sp5100_tco.c:272:16: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'void *' [-Wformat=] 272 | dev_info(dev, "Using 0x%08x for watchdog MMIO address\n", tco->tcobase); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:110:16: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~ include/linux/dev_printk.h:150:51: note: in expansion of macro 'dev_fmt' 150 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~ drivers/watchdog/sp5100_tco.c:272:2: note: in expansion of macro 'dev_info' 272 | dev_info(dev, "Using 0x%08x for watchdog MMIO address\n", tco->tcobase); | ^~~~~~~~ drivers/watchdog/sp5100_tco.c:272:28: note: format string is defined here 272 | dev_info(dev, "Using 0x%08x for watchdog MMIO address\n", tco->tcobase); | ~~~^ | | | unsigned int | %08p drivers/watchdog/sp5100_tco.c: In function 'sp5100_tco_setupdevice_mmio': drivers/watchdog/sp5100_tco.c:345:8: error: implicit declaration of function 'request_mem_region_muxed'; did you mean 'request_mem_region'? [-Werror=implicit-function-declaration] 345 | res = request_mem_region_muxed(EFCH_PM_ACPI_MMIO_PM_ADDR, | ^~~~~~~~~~~~~~~~~~~~~~~~ | request_mem_region >> drivers/watchdog/sp5100_tco.c:345:6: warning: assignment to 'struct resource *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 345 | res = request_mem_region_muxed(EFCH_PM_ACPI_MMIO_PM_ADDR, | ^ cc1: some warnings being treated as errors vim +345 drivers/watchdog/sp5100_tco.c 333 334 static int sp5100_tco_setupdevice_mmio(struct device *dev, 335 struct watchdog_device *wdd) 336 { 337 struct sp5100_tco *tco = watchdog_get_drvdata(wdd); 338 const char *dev_name = SB800_DEVNAME; 339 u32 mmio_addr = 0, alt_mmio_addr = 0; 340 struct resource *res; 341 void __iomem *addr; 342 int ret; 343 u32 val; 344 > 345 res = request_mem_region_muxed(EFCH_PM_ACPI_MMIO_PM_ADDR, 346 EFCH_PM_ACPI_MMIO_PM_SIZE, 347 "sp5100_tco"); 348 349 if (!res) { 350 dev_err(dev, 351 "Memory region 0x%08x already in use\n", 352 EFCH_PM_ACPI_MMIO_PM_ADDR); 353 return -EBUSY; 354 } 355 356 addr = ioremap(EFCH_PM_ACPI_MMIO_PM_ADDR, EFCH_PM_ACPI_MMIO_PM_SIZE); 357 if (!addr) { 358 dev_err(dev, "Address mapping failed\n"); 359 ret = -ENOMEM; 360 goto out; 361 } 362 363 /* 364 * EFCH_PM_DECODEEN_WDT_TMREN is dual purpose. This bitfield 365 * enables sp5100_tco register MMIO space decoding. The bitfield 366 * also starts the timer operation. Enable if not already enabled. 367 */ 368 val = efch_read_pm_reg8(addr, EFCH_PM_DECODEEN); 369 if (!(val & EFCH_PM_DECODEEN_WDT_TMREN)) { 370 efch_update_pm_reg8(addr, EFCH_PM_DECODEEN, 0xff, 371 EFCH_PM_DECODEEN_WDT_TMREN); 372 } 373 374 /* Error if the timer could not be enabled */ 375 val = efch_read_pm_reg8(addr, EFCH_PM_DECODEEN); 376 if (!(val & EFCH_PM_DECODEEN_WDT_TMREN)) { 377 dev_err(dev, "Failed to enable the timer\n"); 378 ret = -EFAULT; 379 goto out; 380 } 381 382 mmio_addr = EFCH_PM_WDT_ADDR; 383 384 /* Determine alternate MMIO base address */ 385 val = efch_read_pm_reg8(addr, EFCH_PM_ISACONTROL); 386 if (val & EFCH_PM_ISACONTROL_MMIOEN) 387 alt_mmio_addr = EFCH_PM_ACPI_MMIO_ADDR + 388 EFCH_PM_ACPI_MMIO_WDT_OFFSET; 389 390 ret = sp5100_tco_prepare_base(tco, mmio_addr, alt_mmio_addr, dev_name); 391 if (!ret) { 392 tco_timer_enable_mmio(addr); 393 ret = sp5100_tco_timer_init(tco); 394 } 395 396 out: 397 if (addr) 398 iounmap(addr); 399 400 release_resource(res); 401 402 return ret; 403 } 404 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
