Re: [PATCH v4 3/3] i2c: smbus: Use device_*() functions instead of of_*()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> +	irq = device_property_match_string(adapter->dev.parent, "interrupt-names",
> +					   "smbus_alert");

I think we should include "linux/property.h" for it. Interesting, the of
header was never included.

> -		irq = of_irq_get_byname(adapter->dev.of_node, "smbus_alert");
> +		irq = fwnode_irq_get_byname(dev_fwnode(adapter->dev.parent),
> +					    "smbus_alert");

Here we should replace of_irq.h with property.h.

Rest looks good!

Happy hacking,

   Wolfram

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux