Re: [PATCH v2 1/5] i2c: Introduce common module to instantiate CCGx UCSI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 27, 2021 at 6:45 PM Shah, Nehal-bakulchandra
<nehal-bakulchandra.shah@xxxxxxx> wrote:
> Thanks for the this patch series.
> On 12/22/2021 9:50 PM, Andy Shevchenko wrote:

...

> > +EXPORT_SYMBOL_GPL(i2c_new_ccgx_ucsi);c
>   it needs MODULE_LICENSE("GPL"); else if driver is built as module it
> fails to probe. However after adding this we validated and it is working
> fine.

Thanks!
Dunno if i need to resend or Wolfram can add it when applying.

...

> > +struct i2c_client *i2c_new_ccgx_ucsi(struct i2c_adapter *adapter, int irq,
> > +                                  const struct software_node *swnode);

> Here, One more suggestion if can be incorporated , instead of passing
> only irq we should pass irq number and irq type. For example in our next
> generation platform , CCGX driver is using IRQF_TRIGGER_FALLING type
> where is default hard coded is IRQF_TRIGGER_HIGH. So in CCGX driver in
> request_threaded_irq function along with passing irq number , irq type
> also can be passed.

We don't add dead code in the kernel, so when you have patches ready
just create another one as a prerequisite that adds that.

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux