Re: [RFC Patch v2 1/3] i2c debug counters as sysfs attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/2/21 6:50 PM, Joe Perches wrote:
On Thu, 2021-12-02 at 18:37 -0800, Sui Chen wrote:
This change adds a few example I2C debug counters as sysfs attributes:
- ber_cnt (bus error count)
- nack_cnt (NACK count)
- rec_fail_cnt, rec_succ_cnt (recovery failure/success count)
- timeout_cnt (timeout count)
- i2c_speed (bus frequency)
- tx_complete_cnt (transaction completed, including both as an initiator
   and as a target)

The function i2c_adapter_create_stats_folder creates a stats directory
in the device's sysfs directory to hold the debug counters. The platform
drivers are responsible for instantiating the counters in the stats
directory if applicable.

Please try to use scripts/checkpatch.pl on your patches and see if
you should be more 'typical kernel style' compliant.

Ideally, use the --strict option too.


Hello Joe,

I thank and really appreciate your spending time commenting on the patch, and on its previous version too. I ran checkpatch.pl and found a few code style fixes on patches 1 and 2. Sorry for not checking the format before sending the email, I will definitely do the format check next time.

Regarding the patch itself, code style aside, we're wondering if this idea of exporting I2C statistics to sysfs looks reasonable? Do we need to accompany this change with design documents too (similar to PCIe AER reporting?)

We have done some more I2C-related performance and reliability tests; however it might take some more efforts to explore those ideas and summarize them into patches/documents. For now we would like to know about the comments on this sysfs attribute change first, since it is the initial step to the larger effort. Any comments will be greatly appreciated.

Thanks,
Sui



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux