Re: [PATCH] i2c: stm32f7: remove noisy and imprecise log messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 30, 2021 at 10:41:37PM +0100, Wolfram Sang wrote:
> 
> > - looking at this area of code again, it appears that the function stm32f7_i2c_release_bus
> > is ALWAYS returning 0. So it should actually be a void function.  I thus
> > propose, if you agree with that, that I propose, and apply a patch PRIOR to your/this patch
> > to change that and remove the error checking of the stm32f7_i2c_release_bus function since it is useless.
> > Is that fine for you ?
> 
> Well, I'd think we can also apply this patch first and then make the
> function void, but I don't really care about the order. But we should do
> both, I agree.
> 

Ok, I thus send a 2 patches serie with mine and yours reworked on top of
mine together. Hope you don't mind.



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux